Adapt Rust's LLVM wrapper to CHERIoT-Platform's LLVM #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdoardo
changed the title
xdoardo
force-pushed
the
llvm-preserve-cheri-tags
branch
4 times, most recently
from
a5d370f to
4e85be5
Compare
seharris
approved these changes
Aug 26, 2025
There was a problem hiding this comment.
Looks ok to me.
By way of a minor nitpick, there are a few files where I feel like it might be slightly tidier to import rustc_codegen_ssa::common::PreserveCheriTags, unless there's a reason not to I haven't noticed? (this wouldn't work in compiler/rustc_codegen_llvm/src/builder.rs because it would conflict with another enum)
I'm thinking of these, though the ones with (?) only use the enum once:
compiler/rustc_codegen_gcc/src/builder.rscompiler/rustc_codegen_gcc/src/intrinsic/mod.rs(?)compiler/rustc_codegen_llvm/src/va_arg.rs(?)compiler/rustc_codegen_ssa/src/mir/block.rs(?)
xdoardo
force-pushed
the
llvm-preserve-cheri-tags
branch
from
4e85be5 to
1ef0eba
Compare
|
1ef0eba patches those files as suggested. |
…d memmove Co-authored-by: Edoardo Marangoni <ecmm@anche.no>
xdoardo
force-pushed
the
llvm-preserve-cheri-tags
branch
from
1ef0eba to
b4835c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a
git amof this commit on top of ourbetabranch, with minor changes. Depends on this PR being merged first.Note that since now (cf. 1.72)
memmoveandmemcpyare part of theBuilderMethodstrait, thePreserveCheriTagsparameters have leaked into GCC as well. Curiously, Cranelift does not complain about it as there are no implementations ofBuilderMethodsinrustc_codegen_cranelift.About CI
This is also a test of the CI set up in the other PR. I think it doesn't make a lot of sense to have it fail at the "check commit" step: perhaps this check could be skipped if the branch the PR comes from is not at distance >1 from the target branch?